Skip to content

fix lint #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025
Merged

fix lint #704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 27 additions & 27 deletions src/server/streamableHttp.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,17 @@ import { z } from "zod";
import { AuthInfo } from "./auth/types.js";

async function getFreePort() {
return new Promise( res => {
const srv = netCreateServer();
srv.listen(0, () => {
const address = srv.address()!
if (typeof address === "string") {
throw new Error("Unexpected address type: " + typeof address);
}
const port = (address as AddressInfo).port;
srv.close((err) => res(port))
});
})
return new Promise(res => {
const srv = netCreateServer();
srv.listen(0, () => {
const address = srv.address()!
if (typeof address === "string") {
throw new Error("Unexpected address type: " + typeof address);
}
const port = (address as AddressInfo).port;
srv.close((_err) => res(port))
});
})
}

/**
Expand Down Expand Up @@ -377,7 +377,7 @@ describe("StreamableHTTPServerTransport", () => {
return { content: [{ type: "text", text: `Hello, ${name}!` }, { type: "text", text: `${JSON.stringify(requestInfo)}` }] };
}
);

const toolCallMessage: JSONRPCMessage = {
jsonrpc: "2.0",
method: "tools/call",
Expand Down Expand Up @@ -828,7 +828,7 @@ describe("StreamableHTTPServerTransport", () => {

// Send request with matching protocol version
const response = await sendPostRequest(baseUrl, TEST_MESSAGES.toolsList, sessionId);

expect(response.status).toBe(200);
});

Expand All @@ -846,7 +846,7 @@ describe("StreamableHTTPServerTransport", () => {
},
body: JSON.stringify(TEST_MESSAGES.toolsList),
});

expect(response.status).toBe(200);
});

Expand All @@ -864,21 +864,21 @@ describe("StreamableHTTPServerTransport", () => {
},
body: JSON.stringify(TEST_MESSAGES.toolsList),
});

expect(response.status).toBe(400);
const errorData = await response.json();
expectErrorResponse(errorData, -32000, /Bad Request: Unsupported protocol version \(supported versions: .+\)/);
});

it("should accept when protocol version differs from negotiated version", async () => {
sessionId = await initializeServer();

// Spy on console.warn to verify warning is logged
const warnSpy = jest.spyOn(console, 'warn').mockImplementation();

// Send request with different but supported protocol version
const response = await fetch(baseUrl, {
method: "POST",
method: "POST",
headers: {
"Content-Type": "application/json",
Accept: "application/json, text/event-stream",
Expand All @@ -887,10 +887,10 @@ describe("StreamableHTTPServerTransport", () => {
},
body: JSON.stringify(TEST_MESSAGES.toolsList),
});

// Request should still succeed
expect(response.status).toBe(200);

warnSpy.mockRestore();
});

Expand All @@ -906,7 +906,7 @@ describe("StreamableHTTPServerTransport", () => {
"mcp-protocol-version": "invalid-version",
},
});

expect(response.status).toBe(400);
const errorData = await response.json();
expectErrorResponse(errorData, -32000, /Bad Request: Unsupported protocol version \(supported versions: .+\)/);
Expand All @@ -923,7 +923,7 @@ describe("StreamableHTTPServerTransport", () => {
"mcp-protocol-version": "invalid-version",
},
});

expect(response.status).toBe(400);
const errorData = await response.json();
expectErrorResponse(errorData, -32000, /Bad Request: Unsupported protocol version \(supported versions: .+\)/);
Expand Down Expand Up @@ -965,12 +965,12 @@ describe("StreamableHTTPServerTransport with AuthInfo", () => {
method: "tools/call",
params: {
name: "profile",
arguments: {active: true},
arguments: { active: true },
},
id: "call-1",
};

const response = await sendPostRequest(baseUrl, toolCallMessage, sessionId, {'authorization': 'Bearer test-token'});
const response = await sendPostRequest(baseUrl, toolCallMessage, sessionId, { 'authorization': 'Bearer test-token' });
expect(response.status).toBe(200);

const text = await readSSEEvent(response);
Expand All @@ -992,7 +992,7 @@ describe("StreamableHTTPServerTransport with AuthInfo", () => {
id: "call-1",
});
});

it("should calls tool without authInfo when it is optional", async () => {
sessionId = await initializeServer();

Expand All @@ -1001,7 +1001,7 @@ describe("StreamableHTTPServerTransport with AuthInfo", () => {
method: "tools/call",
params: {
name: "profile",
arguments: {active: false},
arguments: { active: false },
},
id: "call-1",
};
Expand Down Expand Up @@ -1485,7 +1485,7 @@ describe("StreamableHTTPServerTransport in stateless mode", () => {
// Open first SSE stream
const stream1 = await fetch(baseUrl, {
method: "GET",
headers: {
headers: {
Accept: "text/event-stream",
"mcp-protocol-version": "2025-03-26"
},
Expand All @@ -1495,7 +1495,7 @@ describe("StreamableHTTPServerTransport in stateless mode", () => {
// Open second SSE stream - should still be rejected, stateless mode still only allows one
const stream2 = await fetch(baseUrl, {
method: "GET",
headers: {
headers: {
Accept: "text/event-stream",
"mcp-protocol-version": "2025-03-26"
},
Expand Down