-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: Add CORS configuration for browser-based MCP clients #713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
bda811a
feat: Add CORS configuration for browser-based MCP clients
jerome3o-anthropic 3d381df
Added cors settings to simpleStreamableHttp example server
jerome3o-anthropic 7c374fd
Merged the CORS tips
jerome3o-anthropic 0aea3fe
Merge branch 'main' into jerome/cors-browser-support
jerome3o-anthropic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ import { McpServer } from '../../server/mcp.js'; | |
import { StreamableHTTPServerTransport } from '../../server/streamableHttp.js'; | ||
import { z } from 'zod'; | ||
import { CallToolResult, GetPromptResult, ReadResourceResult } from '../../types.js'; | ||
import cors from 'cors'; | ||
|
||
const getServer = () => { | ||
// Create an MCP server with implementation details | ||
|
@@ -96,6 +97,12 @@ const getServer = () => { | |
const app = express(); | ||
app.use(express.json()); | ||
|
||
// Configure CORS to expose Mcp-Session-Id header for browser-based clients | ||
app.use(cors({ | ||
origin: '*', // Allow all origins - adjust as needed for production | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd probably add a very big "WARNING" here not to include "*" There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If your MCP server will be accessible by browsers, then you might actually want this |
||
exposedHeaders: ['Mcp-Session-Id'] | ||
})); | ||
|
||
app.post('/mcp', async (req: Request, res: Response) => { | ||
const server = getServer(); | ||
try { | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was added in #633
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah up - that's just above this, I've merged them