Revert "fix: add type safety for tool output schemas in ToolCallback" #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhosmer-ant
approved these changes
Jul 3, 2025
There was a problem hiding this comment.
@sushichan044 my apologize for not realizing the consequence of #670 on tool handlers - I assumed (without exhaustive testing) the optionality of the new type param would preserve backward compatibility.
I haven't thought it through in detail, but it feels plausible that the addition could be made in a backwards-compatible way. Please let me know if you try!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #670
Addressing this issue: #670 (comment)
Forcibly casting a type onto
CallToolResultwas a bad modification.