Add missing app.listen error handling to server examples #749
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Express
app.listen
's callback accepts an optional error argument, which needs checking to avoid surprising behaviour.(note: README.md already shows an example of such error handling)
Motivation and Context
When one of the ports used by the examples is already in use, users will unknowingly hit the previously running server instead of being notified of an error.
How Has This Been Tested?
Concurrent runs of
npx -y tsx src/examples/server/simpleStreamableHttp.ts
and its sibling examples.Breaking Changes
None
Types of changes
Checklist