Skip to content

Add missing app.listen error handling to server examples #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025

Conversation

ochafik
Copy link
Contributor

@ochafik ochafik commented Jul 9, 2025

Express app.listen's callback accepts an optional error argument, which needs checking to avoid surprising behaviour.

(note: README.md already shows an example of such error handling)

Motivation and Context

When one of the ports used by the examples is already in use, users will unknowingly hit the previously running server instead of being notified of an error.

How Has This Been Tested?

Concurrent runs of npx -y tsx src/examples/server/simpleStreamableHttp.ts and its sibling examples.

Breaking Changes

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@ochafik ochafik marked this pull request as ready for review July 9, 2025 10:34
Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ihrpr ihrpr merged commit d681f14 into main Jul 9, 2025
5 checks passed
@ihrpr ihrpr deleted the ochafik/check-addrinuse branch July 9, 2025 11:36
@ochafik ochafik requested review from cliffhall and removed request for cliffhall July 9, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants