Skip to content

Conversation

cbatis
Copy link
Contributor

@cbatis cbatis commented Mar 18, 2021

Description

Related issues

Tests

Checklist

  • I read the Contributing guide.
  • I update the documentation and if the case the README.md file.
  • I am willing to follow-up on review comments in a timely manner.

@cbatis cbatis requested a review from raul-casallas March 25, 2021 17:10
raul-casallas
raul-casallas previously approved these changes Mar 25, 2021
Copy link
Contributor

@raul-casallas raul-casallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

package.json Outdated
@@ -1,22 +1,37 @@
{
"name": "modzy-sdk",
"version": "1.0.1",
"version": "0.7.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing the intention here was to align this SDK version with our 0.7.2 release of Modzy, but we should never push a new version that has a lower version number otherwise it will never get pulled when someone runs yarn install.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the version bump should be 1.0.2 or something like that.

@cbatis cbatis merged commit 1e9e086 into main Mar 26, 2021
@cbatis cbatis deleted the readmeUpdates branch March 26, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants