CLOUDP-336001: Remove legacy atlas client #2579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
652a929 to
d3710d9
Compare
igor-karpukhin
approved these changes
Aug 11, 2025
| return reflect.DeepEqual(currentCopy, newCopy), nil | ||
| } | ||
|
|
||
| func deepCopy[T any](src *T) (*T, error) { |
There was a problem hiding this comment.
Isn't there a DeepCopy() method generated by the kubebuilder?
There was a problem hiding this comment.
It's not copying Kube struct by copying sdk structs, that's why I added it.
| @@ -170,7 +169,7 @@ func (ds *ProductionAtlasDeployments) DeploymentIsReady(ctx context.Context, pro | |||
| if err != nil { | |||
| return false, fmt.Errorf("failed to get cluster %q status %w", deploymentName, err) | |||
| } | |||
| return clusterStatus.GetChangeStatus() == string(mongodbatlas.ChangeStatusApplied), nil | |||
| return clusterStatus.GetChangeStatus() == "APPLIED", nil | |||
There was a problem hiding this comment.
nit: magic value. Better to move to a const
andrpac
approved these changes
Aug 11, 2025
roothorp
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Proof of Work
Checklist
Reminder (Please remove this when merging)