CLOUDP-295785 - using build_info.json in new atomic pipeline #317
+846
−557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix build scenario Remove create and push manifests Continue improvement to main Simplify main and build_context missed Pass Build Configuration object directly Use legacy and new pipeline Fix Remove --include Rename MCO test image Multi platform builds, with buildx TODOs Implement is_release_step_executed() Fix init appdb image Import sort black formatting Some cleaning and version adjustments Adapt main to new build config Add buildscenario to buildconfig Handle build env Renaming, usage of high level config All images build pass on EVG Lint Explicit image type, support custom build_path Replace old by new pipeline in EVG Add documentation Split in multiple files, cleanup WIP, passing builds on staging temp + multi arch manifests Replace usage of sonar Remove namespace Remove pin_at and build_id Copied pipeline, removed daily builds and --exclude
This reverts commit 426e522.
…d-versions # Conflicts: # scripts/release/atomic_pipeline.py # scripts/release/build/image_build_process.py # scripts/release/build_context.py
…d-versions # Conflicts: # scripts/release/atomic_pipeline.py # scripts/release/build/image_build_process.py # scripts/release/pipeline_main.py
nammn
reviewed
Aug 8, 2025
nammn
reviewed
Aug 8, 2025
| @@ -6,9 +6,7 @@ | |||
| # | |||
| # Ref: https://cryptography.io/en/latest/installation/#building-cryptography-on-linux | |||
| # | |||
| ARG GOLANG_VERSION | |||
There was a problem hiding this comment.
to align with other Dockerfiles, where Golang version is specified in base image
# Conflicts: # scripts/release/atomic_pipeline.py # scripts/release/pipeline_main.py
Merged
# Conflicts: # scripts/release/atomic_pipeline.py
nammn
approved these changes
Aug 11, 2025
MaciejKaras
pushed a commit
that referenced
this pull request
Aug 11, 2025
# Summary Master patches are broken because they build with `latest` tag only, while the patch still need the `patch_id` tagged images. This PR fixes this issue to get master green again, but remove builds to `latest`. They will be added again in #317, using build_info. Not pushing to latest only impacts local testing for dev, as we use them to have the most recently built versions from master. It won't break local development, but it means the image used will be slightly outdated. ## Proof of Work I tested it by forcing to return the patch ID and dumping the relevant variables in this patch: https://spruce.mongodb.com/version/6899d033f94ad4000694cf89/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC But the relevant environment variable (`is_patch` being false, as described in the added documentation) will be set to the right value only when merging to master.
# Conflicts: # scripts/release/build_context.py
| @@ -57,7 +57,7 @@ def load_build_info(scenario: BuildScenario, | |||
| f""" | |||
| Load build information based on the specified scenario. | |||
|
|
|||
| :param scenario: BuildScenario enum value indicating the build scenario (e.g., PATCH, STAGING, RELEASE). | |||
| :param scenario: BuildScenario enum value indicating the build scenario (e.g. "development", "patch", "staging", "release"). "development" scenario will return build info for "patch" scenario. | |||
There was a problem hiding this comment.
nit: do we really need to introduce a new build scenario development if we are just treating it as patch. Should we consider adding a comment on the method that for development just pass patch?
There was a problem hiding this comment.
The development scenario is useful for local development, when you want to publish with latest tag etc. It is synthetic and we could later decide to drop it if we extract the version and scenario out of the atomic_pipeline.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR focuses on using
build_info.jsoninformation inatomic_pipeline.pycode. The logic is mostly hidden inimage_build_config_from_argsfunction. It is binding the parts from:build_info.jsonwith information for building imagesSection in Atomic Releases TD that describes the
build_info.jsonand how it is used in the image building process.build_info.jsonmeko-testsandmco-testsimages inbuild_info.jsonagentandops-managerimages inbuild_info.jsonimages_signing.pyfromscripts/evergreen/releaseProof of Work
CI tests passing + updated unit tests
Checklist
skip-changeloglabel if not needed