-
Notifications
You must be signed in to change notification settings - Fork 13
CLOUDP-295785 - add pipeline_main.py
extended help
#334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix build scenario Remove create and push manifests Continue improvement to main Simplify main and build_context missed Pass Build Configuration object directly Use legacy and new pipeline Fix Remove --include Rename MCO test image Multi platform builds, with buildx TODOs Implement is_release_step_executed() Fix init appdb image Import sort black formatting Some cleaning and version adjustments Adapt main to new build config Add buildscenario to buildconfig Handle build env Renaming, usage of high level config All images build pass on EVG Lint Explicit image type, support custom build_path Replace old by new pipeline in EVG Add documentation Split in multiple files, cleanup WIP, passing builds on staging temp + multi arch manifests Replace usage of sonar Remove namespace Remove pin_at and build_id Copied pipeline, removed daily builds and --exclude
This reverts commit 426e522.
…d-versions # Conflicts: # scripts/release/atomic_pipeline.py # scripts/release/build/image_build_process.py # scripts/release/pipeline_main.py
# Conflicts: # scripts/release/atomic_pipeline.py # scripts/release/pipeline_main.py
# Conflicts: # scripts/release/atomic_pipeline.py
# Conflicts: # scripts/release/build_context.py
MCK 1.3.0 Release NotesBug Fixes
Other Changes
|
pipeline_main.py
extended help
# Conflicts: # scripts/release/atomic_pipeline.py # scripts/release/pipeline_main.py
type=str, | ||
choices=supported_scenarios, | ||
help=f"""Override the build scenario instead of inferring from environment. Options: {", ".join(supported_scenarios)}. | ||
Default is to infer from environment variables. For '{BuildScenario.DEVELOPMENT}' the '{BuildScenario.PATCH}' scenario is used to read values from 'build_info.json'""", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think
For '{BuildScenario.DEVELOPMENT}' the '{BuildScenario.PATCH}' scenario is used to read values from 'build_info.json
is confusing.
Depending on if we decide to change this behaviour or keep it, we may want to add a sentence to explain why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not entirely sure what direction we should go. DEVELOPMENT makes sense, but we rarely build our own images, rather instruct evg to build it for us. We can reuse PATCH configuration to build everything we want by overriding other settings like registry and build scenario
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add a task to our todo list to clean this up later
Summary
Adding more help information for the
scripts.release.pipeline_main
python script.Proof of Work
Checklist
skip-changelog
label if not needed