chore: Deal with there being no known/active connection when doing autocomplete #542
Conversation
| @@ -50,6 +50,7 @@ | |||
| "@mongosh/shell-api": "^3.11.0" | |||
| }, | |||
| "dependencies": { | |||
| "@mongosh/shell-api": "^3.11.0", | |||
There was a problem hiding this comment.
RE: #541
Turns out we have a .npmrc file that sets. legacy-peer-deps=true for some reason and therefore right now it isn't installing shell-api at all.
There was a problem hiding this comment.
This should be a devDependency, I'll just push that change here to the PR
There was a problem hiding this comment.
Why, though? We import it at runtime.
There was a problem hiding this comment.
Yeah, as a peer dependency.
If you specify a regular dependency, that's strictly stronger than a peer or dev dependency, so you could just leave it out from the latter categories.
But the goal here is to ensure that our products use a version of the shell-api package that's consistent with what the product uses in other areas of its code; and for that, peer dependencies are the right tool. And if the peer dependency is needed at development time, then peer + dev is the typical pattern for that
| @@ -50,6 +50,7 @@ | |||
| "@mongosh/shell-api": "^3.11.0" | |||
| }, | |||
| "dependencies": { | |||
| "@mongosh/shell-api": "^3.11.0", | |||
There was a problem hiding this comment.
This should be a devDependency, I'll just push that change here to the PR
No description provided.