Skip to content

chore(NODE-7041): update dependencies and use standard Node team eslint configuration #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 13, 2025

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Aug 12, 2025

Description

What is changing?

Updates all stale dev dependencies to latest. Additionally, as discussed in slack, I adjusted the eslint configuration to use our standard eslint tooling (adapted from @mongodb-js/zstd, a simpler config than the driver's). This also required reformatting.

Finally, adopting @typescript-eslint/eslint-plugin breaks lint on Node16 because @typescript-eslint/eslint-plugin uses structuredClone. I fixed this by moving lint to a separate Github action that runs on Node22 instead of linting each test variant (other repos of ours only run lint on latest).

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

dependabot bot and others added 5 commits August 1, 2025 01:50
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.17.0 to 24.1.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-version: 24.1.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@baileympearson baileympearson changed the title No story deps bump and lint chore(NODE-7041): update dependencies and use standard Node team eslint configuration Aug 12, 2025
@baileympearson baileympearson marked this pull request as ready for review August 12, 2025 19:23
@baileympearson baileympearson requested a review from a team as a code owner August 12, 2025 19:23
Copy link
Collaborator

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw lgtm!

@durran durran self-assigned this Aug 13, 2025
@durran durran merged commit d324bac into main Aug 13, 2025
30 checks passed
@durran durran deleted the no-story-deps-bump-and-lint branch August 13, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants