feat: add back the connect tool #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR re-enables the connect tool by updating tests, removing temporary skips, and integrating the ConnectTool into the main tools array. Key changes include:
- Updating the describeWithMongoDB signature and connectMcpClient implementation to call the connect tool when available.
- Reviving previously skipped integration tests for the connect tool.
- Refactoring import and configuration logic in session and server modules.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/tools/mongodb/mongodbHelpers.ts | Removed the describeFn parameter and updated connectMcpClient to conditionally call the connect tool. |
| tests/integration/tools/mongodb/metadata/connect.test.ts | Unsuppressed tests for the connect tool by removing describe.skip and adjusting parameters. |
| src/tools/mongodb/tools.ts | Re-enabled the ConnectTool import and inclusion in MongoDbTools. |
| src/session.ts | Refactored connection handling by inlining provider assignment and updating the productDocsLink. |
| src/server.ts | Removed the configuration validation for MongoDB/Atlas credentials. |
Comments suppressed due to low confidence (1)
src/server.ts:174
- The removal of configuration validation in validateConfig might lead to silent misconfigurations if neither Atlas credentials nor a MongoDB connection string are provided. Ensure that the calling context or higher-level logic adequately handles missing configuration.
private async validateConfig(): Promise<void> {
gagik
approved these changes
May 7, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
blva
approved these changes
May 7, 2025
nirinchev
added a commit
that referenced
this pull request
May 8, 2025
* main: (40 commits) chore: add more details for some api errors (#219) fix: use ejson parsing for stdio messages (#218) docs: improve getting started experience (#217) feat: support flex clusters to atlas tools (#182) chore: enforce access list (#214) feat: add back the connect tool (#210) Update connection string app name if not present (#199) chore: update docs with more Service Accounts mentions (#209) chore(deps-dev): bump eslint-plugin-prettier from 5.2.6 to 5.4.0 (#205) chore(deps-dev): bump @types/node from 22.15.3 to 22.15.9 (#204) chore(deps-dev): bump typescript-eslint from 8.31.1 to 8.32.0 (#206) chore(deps-dev): bump eslint from 9.25.1 to 9.26.0 (#207) chore: add recommended extensions and settings (#200) fix: fork checks (#194) docs: correct the link for VSCode's MCP usage (#186) chore: switch to a matrix for forks (#191) chore: skip Atlas Tests and don't track coverage for fork contributions (#188) fix: db user test error (#187) fix: improve api error messages (#176) chore: update quickstart with mcpServers (#185) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.