fix: use ejson parsing for stdio messages #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the BSON type deserialization issue by switching to EJSON parsing for stdio messages, ensuring that BSON types like ObjectId, UUID, and Decimal128 are properly reconstructed from incoming messages.
- Added unit tests for EJSON transport behavior.
- Updated integration tests to verify find tool output with BSON type values.
- Replaced direct usage of StdioServerTransport with a custom EJSON-enabled transport.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/EJsonTransport.test.ts | New unit tests to validate EJSON-based deserialization. |
| tests/integration/tools/mongodb/read/find.test.ts | Added integration test to verify find tool with BSON types. |
| tests/integration/helpers.ts | Enhanced expectDefined to check for null as well as undefined. |
| src/index.ts | Modified to initialize the EJSON transport instead of the default. |
| src/helpers/EJsonTransport.ts | Introduced EJsonReadBuffer and factory function for EJSON parsing. |
Comment on lines
+40
to
+42
| export function createEJsonTransport(): StdioServerTransport { | ||
| const server = new StdioServerTransport(); | ||
| server["_readBuffer"] = new EJsonReadBuffer(); |
There was a problem hiding this comment.
[nitpick] Accessing a private property via server["_readBuffer"] may lead to maintainability issues if the underlying implementation changes. Consider exposing a dedicated method or refactoring the transport to safely update the read buffer.
Suggested change
| export function createEJsonTransport(): StdioServerTransport { | |
| const server = new StdioServerTransport(); | |
| server["_readBuffer"] = new EJsonReadBuffer(); | |
| class EJsonStdioServerTransport extends StdioServerTransport { | |
| setReadBuffer(buffer: EJsonReadBuffer): void { | |
| (this as any)._readBuffer = buffer; // Accessing private property safely within the subclass | |
| } | |
| } | |
| export function createEJsonTransport(): StdioServerTransport { | |
| const server = new EJsonStdioServerTransport(); | |
| server.setReadBuffer(new EJsonReadBuffer()); |
Copilot uses AI. Check for mistakes.
blva
approved these changes
May 7, 2025
gagik
approved these changes
May 8, 2025
nirinchev
added a commit
that referenced
this pull request
May 8, 2025
* main: (40 commits) chore: add more details for some api errors (#219) fix: use ejson parsing for stdio messages (#218) docs: improve getting started experience (#217) feat: support flex clusters to atlas tools (#182) chore: enforce access list (#214) feat: add back the connect tool (#210) Update connection string app name if not present (#199) chore: update docs with more Service Accounts mentions (#209) chore(deps-dev): bump eslint-plugin-prettier from 5.2.6 to 5.4.0 (#205) chore(deps-dev): bump @types/node from 22.15.3 to 22.15.9 (#204) chore(deps-dev): bump typescript-eslint from 8.31.1 to 8.32.0 (#206) chore(deps-dev): bump eslint from 9.25.1 to 9.26.0 (#207) chore: add recommended extensions and settings (#200) fix: fork checks (#194) docs: correct the link for VSCode's MCP usage (#186) chore: switch to a matrix for forks (#191) chore: skip Atlas Tests and don't track coverage for fork contributions (#188) fix: db user test error (#187) fix: improve api error messages (#176) chore: update quickstart with mcpServers (#185) ...
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around the issue where we receive bson types serialized as ejson, but not converted into the corresponding types.
Fixes #211