chore: provides dedicated cli and library entrypoints - MCP-6 #325
+960
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally this commit moves the cli entry point from src/index.ts to src/cli.ts and adds a lib entrypoint in src/lib.ts to export required entities in vscode extension tsconfig.build.json has been updated to account for the fact that the environment for module resolution will be bundler.
node-machine-id is a commonjs module and module.exports from a commonjs module should be imported using namespace imports as it cannot be guaranteed that for those exports a synthetic default export will be created or not.
be35dfa to
0fcc9f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Important changes in this PR are summarised here:
src/index.tstosrc/cli.ts. The same has been reflected in package json's entry as well underbinsrc/lib.ts) has been added for exporting entities to be used by other projects (vscode). For now it exports only the entities necessary for a server creation as per the following commit.tscto emit files such that they could be imported in vscode (which is using classic module resolution) without having import errors and errors in dependency resolution during runtime. So far only bundling approach worked out.tscand also referenced in package.json for type resolution in other projects.filesentry in package.json to fix this.All the existing tests pass. What this PR lacks and would be great to have is some type of CLI tests for running the MCP server, possibly also doing some basic e2e. This would give more confidence in doing these bundling changes.
Checklist