fix: index tests #331
Merged
fix: index tests #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses failing tests on main by updating test configurations and workflow conditions to ensure tests run consistently.
- Updated test configuration in mongodbHelpers to include a specific MongoDB version.
- Adjusted the aggregate call in the AggregateTool by removing unused options parameters.
- Modified workflow conditionals to run tests on push events as well as pull requests.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/integration/tools/mongodb/mongodbHelpers.ts | Added MongoDB version configuration to enforce a consistent test environment. |
| src/tools/mongodb/read/aggregate.ts | Removed extra options from the aggregate call, streamlining the API usage during index checks. |
| .github/workflows/code_health.yaml | Updated workflow conditions to run tests on push events, preventing missed failures. |
Comments suppressed due to low confidence (2)
src/tools/mongodb/read/aggregate.ts:32
- Confirm that the removal of the options parameters is intentional and that the default behavior of the aggregate function meets the index check requirements.
.aggregate(database, collection, pipeline)
.github/workflows/code_health.yaml:14
- Verify that the updated condition correctly distinguishes between push and pull request events so that tests are not inadvertently triggered in undesired scenarios.
if: github.event_name == 'push' || (github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository)
| @@ -70,6 +70,7 @@ export function setupMongoDBIntegrationTest(): MongoDBIntegrationTest { | |||
| tmpDir: dbsDir, | |||
| logDir: path.join(tmpDir, "mongodb-runner", "logs"), | |||
| topology: "standalone", | |||
| version: "8.0.10", | |||
There was a problem hiding this comment.
[nitpick] Consider adding a comment to clarify why MongoDB version 8.0.10 is hard-coded here or parameterize it for future flexibility.
Suggested change
| version: "8.0.10", | |
| version: DEFAULT_MONGODB_VERSION, |
Copilot uses AI. Check for mistakes.
fmenezes
commented
Jun 30, 2025
src/tools/mongodb/read/aggregate.ts
Outdated
| @@ -29,7 +29,7 @@ export class AggregateTool extends MongoDBToolBase { | |||
| if (this.config.indexCheck) { | |||
| await checkIndexUsage(provider, database, collection, "aggregate", async () => { | |||
| return provider | |||
| .aggregate(database, collection, pipeline, {}, { writeConcern: undefined }) | |||
| .aggregate(database, collection, pipeline) | |||
kmruiz
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Tests are currently failing on main, we never noticed because we are not running tests against merged commits only PRs
Checklist