chore: allows ConnectionManager to be injected via TransportRunner MCP-131 #481
+203
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmruiz
requested changes
Aug 27, 2025
kmruiz
reviewed
Aug 27, 2025
6298977 to
998140f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ConnectionManager interface to allow injection of custom ConnectionManager implementations via TransportRunner constructors. This enables VSCode integration by allowing the VSCode extension to provide its own ConnectionManager implementation that shares connection state with existing VSCode connections.
- Extracts an abstract ConnectionManager base class with
connectanddisconnectas abstract methods - Moves the existing ConnectionManager implementation to MCPConnectionManager
- Modifies TransportRunner classes to accept a factory function for creating ConnectionManager instances
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/common/connectionManager.ts | Creates abstract base ConnectionManager with interface definitions |
| src/common/mcpConnectionManager.ts | Implements concrete MCPConnectionManager with existing connection logic |
| src/transports/base.ts | Adds CreateConnectionManagerFn type and modifies constructor to accept factory function |
| src/transports/stdio.ts | Updates constructor to use ConnectionManager factory function |
| src/transports/streamableHttp.ts | Updates constructor to use ConnectionManager factory function |
| src/index.ts | Creates factory function for MCPConnectionManager in main entry point |
| src/lib.ts | Exports new ConnectionManager interface and related types |
| tests/* | Updates test files to use MCPConnectionManager and new event interface |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
51f2fdf to
8258b3e
Compare
kmruiz
reviewed
Aug 28, 2025
This commit extracts an abstract class ConnectionManager out of MCPConnectionManager and modifies the TransportRunner interface to have the ConnectionManager implementation injected through a factory function. Contains a small drive by fix for making the ConnectionManager event emitting internal to the class itself.
33b85d4 to
71680ab
Compare
kmruiz
approved these changes
Aug 28, 2025
nirinchev
reviewed
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR modifies the interface for our TransportRunners to allow injecting a ConnectionManager implementation. This will enable VSCode integration by allowing VSCode extension to pass its own implementation of ConnectionManager.
To allow subclassing, an abstract ConnectionManager is extracted out from existing implementation with
connect,disconnectas the abstract methods.The VSCode implementation of ConnectionManager differs slightly from our implementation of ConnectionManager (MCPConnectionManager) which is why this interface modification was called for. The
VSCodeMCPConnectionManager.connectis not as involved as our implementation, we literally borrow the connect options from an existing connection in VSCode extension and use those to create a new instance of NodeServiceProvider which essentially shares the connection state. Additionally that implementation also implements logic to switch to different connections on demand(when active connection in extension changes).The VSCode PR is here for reference.
Checklist