fix(connection): support for multiple hosts urls #327 #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where MongoDB connection strings with multiple hosts were incorrectly parsed as arrays instead of being treated as valid URL strings. The fix adds special handling for MongoDB URLs in the environment variable parsing logic.
- Added MongoDB protocol detection to skip preprocessing of connection strings
- Added test coverage for multiple-host MongoDB URLs
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/common/config.ts | Added MongoDB URL detection to prevent preprocessing of connection strings starting with mongodb:// or mongodb+srv:// |
| tests/unit/common/config.test.ts | Added test case to verify multiple-host MongoDB URLs are preserved correctly |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
11 tasks
Environment variables are always strings, but we will add this check in case we receive something that is not process.env.
CLI parsing doesn't have that issue but, in case we refactor add a test to ensure we don't regress here.
blva
reviewed
Sep 4, 2025
Pull Request Test Coverage Report for Build 17461171989Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Bug: MongoDB URLs passed as environment variables that contain multiple hosts are treated as arrays instead of actual URLS.
Fix: When the environment variable contents start with a mongodb connection protocol (mongodb://, mongodb+srv://) it skips preprocessing the contents and stores it in the config as is.
Fixes:
Checklist