fix: report correct number of projects #523
Merged
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the project counting logic within the MongoDB Atlas project listing tool. The issue was that the code was incorrectly counting characters in a string instead of the actual number of projects returned from the API.
- Updates the project count calculation to use the actual number of projects from the API response
- Modifies the test to verify the count against the parsed table data length for accuracy
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tools/atlas/read/listProjects.ts | Fixed project count to use data.results.length instead of rows.length |
| tests/integration/tools/atlas/projects.test.ts | Updated test to validate project count against parsed data length |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
himanshusinghs
approved these changes
Sep 8, 2025
blva
approved these changes
Sep 8, 2025
Pull Request Test Coverage Report for Build 17486542708Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This was previously counting characters, not projects.