fix(readOnly): Do not allow $out and $merge in readOnly mode #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR prevents MongoDB aggregation pipelines from using $out and $merge stages when the system is in read-only mode, ensuring data integrity by blocking operations that could write or modify data outside the current database.
- Adds validation to reject
$outand$mergestages in read-only mode - Introduces a new error code for forbidden write operations
- Includes comprehensive test coverage for both restricted stages
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/tools/mongodb/read/aggregate.ts | Adds stage validation logic to prevent write operations in read-only mode |
| src/common/errors.ts | Introduces new error code for forbidden write operations |
| tests/integration/tools/mongodb/read/aggregate.test.ts | Adds test cases to verify $out and $merge stages are blocked in read-only mode |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Pull Request Test Coverage Report for Build 17494762061Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
MongoDB pipelines can generate new data and store it in another database, collection, S3 bucket and more using both the $merge and $out stages. We are disabling these stages in readOnly mode to avoid unexpected behaviour for the user.
Checklist