Skip to content

chore: allow opting out of the welcome screen VSCODE-697 #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

chore: allow opting out of the welcome screen VSCODE-697 #1053

merged 1 commit into from
May 23, 2025

Conversation

nirinchev
Copy link
Contributor

Description

Adds a config that allows users to opt out of showing the welcome screen after the extension is installed.

Checklist

  • New tests and/or benchmarks are included

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@nirinchev nirinchev requested a review from gagik May 22, 2025 20:11
gagik
gagik approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@gagik gagik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you configure an extension before installing it? Is this for workspace configurations?
Just seems like a very minor annoyance but looks good to me otherwise

@nirinchev
Copy link
Contributor Author

I believe you can - as long as you know what the magic config options are, the configuration should be picked up once the extension activates. This is intended to be used for preconfigured environments - e.g. Github codespaces or similar, so the team setting it up would be able to opt out of displaying the welcome screen.

@nirinchev nirinchev added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label May 23, 2025
@nirinchev nirinchev changed the title chore: allow opting out of the welcome screen chore: allow opting out of the welcome screen VSCODE-697 May 23, 2025
@nirinchev nirinchev removed the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label May 23, 2025
@nirinchev nirinchev merged commit cb3fde1 into main May 23, 2025
11 of 12 checks passed
@nirinchev nirinchev deleted the ni/welcome-opt-out branch May 23, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gagik gagik gagik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nirinchev @gagik