VSCODE-639: Replace regex fragment matching with streaming KMP #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love it!! Looking forward to this work being finished and merged 🔥 |
6acc41f to
c8f09f4
Compare
Anemy
approved these changes
Oct 21, 2024
| // Finish up anything not streamed yet. | ||
| if (contentSinceLastIdentifier.length > 0) { | ||
| processStreamFragment(contentSinceLastIdentifier); | ||
| for await (const fragment of inputIterable) { |
There was a problem hiding this comment.
One change in behavior that will happen is when a fragment is very large, and could contain two code blocks. It would now print all of the fragment before it adds the actions.
This won't impact our use of this since the fragments are pretty much always 2-4 characters.
There was a problem hiding this comment.
Thanks for spotting that. The fix for it was simple enough, so I added it anyway just to be on the safe side.
* main: VSCODE-640: Adapt message content access to latest vscode API (#857) Update changelog (#856)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I got nerd-sniped by #835, and wanted to try out a regex-less implementation of the identifier matching algorithm. I've implemented a stateful streaming Knuth-Morris-Pratt algorithm for the identifier matching and then a stateful matcher for the content. Those could have been trivially combined, but I opted to keep them separate to 1) keep the concerns more cleanly separate and 2) to have the building blocks available in case we need to do a simple substring search in the stream without extracting some content between the identifiers.
While I think this approach is slightly more readable and should (theoretically) be more performant, I don't believe we should try and get it in before the code freeze as it's not fixing an actual bug.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes