fix: hide preset connections from the Remove Connection command VSCODE-674 #969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1811dd to
5be9bd3
Compare
nirinchev
approved these changes
Mar 7, 2025
src/connectionController.ts
Outdated
| @@ -743,7 +743,11 @@ export default class ConnectionController { | |||
| async onRemoveMongoDBConnection(): Promise<boolean> { | |||
| log.info('mdb.removeConnection command called'); | |||
|
|
|||
| const connectionIds = Object.keys(this._connections); | |||
| const connectionIds = Object.entries(this._connections).filter( | |||
| ([, connection]) => | |||
There was a problem hiding this comment.
[nit] consider mapping this tuple to an object with id and connection fields - that way it'll be easier to know what you're destructuring into without having to remember what value is at what index.
There was a problem hiding this comment.
Saw that you're out today, so I went ahead and applied this suggestion - happy to revert it if you disagree with the change, but wanted to merge the PR to get into the next release
There was a problem hiding this comment.
no sounds good, sorry wasn't out for the day just for an hour 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is actually possible to end up "removing" a preset connection when using the command palette...
It does "remove" the connection for the session and doesn't error but this removal doesn't persist on refresh (since the preset connection just gets reloaded from the config).
This changes it so we instead filter that.