Use newest versions of PHPUnitBridge #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
approved these changes
Dec 8, 2023
OskarStark
reviewed
Dec 8, 2023
| @@ -26,7 +26,7 @@ | |||
| "symfony/browser-kit": "^6.3 || ^7.0", | |||
| "symfony/filesystem": "^6.3 || ^7.0", | |||
| "symfony/framework-bundle": "^6.3.5 || ^7.0", | |||
| "symfony/phpunit-bridge": "^6.3 || ^7.0", | |||
| "symfony/phpunit-bridge": "~6.3.10 || ^6.4.1 || ^7.0.1", | |||
There was a problem hiding this comment.
Is there a specific reason to user ~ over ^?
There was a problem hiding this comment.
We don't want 6.4.0 to be installed.
There was a problem hiding this comment.
From what I understand 6.4.0 can never be installed due to the second version definition ^6.4.1
There was a problem hiding this comment.
There was a problem hiding this comment.
I agree, but then the second kicks in, np?
It would be simpler to read like this:
^6.3.10 || ^7.0.1
adding a conflict for =6.4.0
alcaeus
added a commit
that referenced
this pull request
Dec 8, 2023
* 0.1: Use newest versions of PHPUnitBridge (#12)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues in CI that were first reported in symfony/symfony#52844. Sending this PR to 0.1 so we can continue to make fixes there.