Remove parameter name usage for AutowireDatabase #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
suggested changes
Dec 8, 2023
Closed
GromNaN
reviewed
Dec 9, 2023
| @@ -48,7 +48,7 @@ static function (Database $mydb): void { | |||
|
|
|||
| $this->assertSame(Database::class, $definition->getClass()); | |||
| $this->assertEquals($autowire->value, $definition->getFactory()); | |||
| $this->assertSame('mydb', $definition->getArgument(0)); | |||
| $this->assertSame('%MongoDB\Client.default_database%', $definition->getArgument(0)); | |||
There was a problem hiding this comment.
That's an ugly parameter name. Can we find something more conventional?
There was a problem hiding this comment.
That's an ugly parameter name. Can we find something more conventional?
I'll address that in a separate PR - maybe we can always use <clientId>.default_database
OskarStark
approved these changes
Dec 9, 2023
1a6f95f to
2a2550c
Compare
Before this PR, there was no way to inject a |
GromNaN
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is, there is no way to autowire the default database without explicitly specifying the name, instead it will always use the parameter name. To work around this, we remove usage of the parameter name and fall back to the default database; not specifying a
default_databaseoption or thedatabaseparameter in theAutowireDatabaseattribute will result in an exception. We could use some magic to fall back to the parameter name if no default database was set, but I don't believe that results an improvement and only makes for more confusing rules.