Allow specifying options in AutowireDatabase and AutowireCollection #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
reviewed
Dec 9, 2023
| @@ -44,6 +46,7 @@ public function __construct( | |||
| private readonly ?string $collection = null, | |||
| private readonly ?string $database = null, | |||
| ?string $client = null, | |||
| private readonly string|DocumentCodec|null $codec = null, | |||
There was a problem hiding this comment.
How would you pass a DocumentCodec instance?
There was a problem hiding this comment.
I added an example, but it's rather straightforward:
use MongoDB\Bundle\Attribute\AutowireCollection;
use MongoDB\Collection;
use MongoDB\Driver\ReadPreference;
class MyService
{
public function __construct(
#[AutowireCollection(codec: Codec::class, readPreference: new ReadPreference('secondary'))]
private Collection $myCollection,
) {}
}
GromNaN
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
optionsparameter fromAutowireCollectionandAutowireDatabase, and instead adds arguments for all options supported by theselectCollectionandselectDatabasemethods. When passing a string value, it is treated as a service reference to be injected. The only exception to this is thetypeMapparameter, where a string is treated as a parameter name since it will resolve to an array value, not a service.