-
Notifications
You must be signed in to change notification settings - Fork 3
Add MongoDB profiler #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
commented
Nov 10, 2023
@@ -70,7 +72,7 @@ private function createClients(string $defaultClient, array $clients, ContainerB | |||
$clientDefinition->setArgument('$uri', $configuration['uri']); | |||
$clientDefinition->setArgument('$uriOptions', $configuration['uriOptions'] ?? []); | |||
$clientDefinition->setArgument('$driverOptions', $configuration['driverOptions'] ?? []); | |||
|
|||
$clientDefinition->addTag('mongodb.client', ['name' => $client]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name is used by DataCollectorPass
and displayed in the profiler panel.
The tag didn't need to be in the service prototype.
GromNaN
commented
Nov 13, 2023
OskarStark
reviewed
Nov 13, 2023
0fbd19c
to
b9b5124
Compare
alcaeus
approved these changes
Dec 9, 2023
Great work @GromNaN 👌🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like I don't have waited for @alcaeus to give me time to work on the profiler. It's based largely on the Doctrine profiler.
Logo comes from https://www.mongodb.com/brand-resources and was reworks to adjust the colors and the size.
Toolbar
Profiler panel
Performance panel
"Copy as mongosh"Explain