Add annotations to operator deployment #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 request for merging this |
pcallewaert
approved these changes
Apr 3, 2025
|
@hitman99 Looks good, can we get this merged? |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR adds annotations configuration for the operator
Deploymentresource.Main use case is that when using an externally rotating secret (i.e. Managed secrets in AWS RDS that rotate every 7 days) there is the need to make the operator read the new secret. For this I use the Reloader, which requires you to annotate the deployment with the secret that it should be monitoring to decide if the deployment needs to be restarted.
I have followed the same pattern as
podAnnotationsfor consistentcy.I am not bumping any version, but let me know if I should bump the chart version or it is something that you do when releasing.
Thanks for all the good work in this operator!