Fix DropRole in Azure for PG16 #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1d40bc4 to
0f1ef35
Compare
0f1ef35 to
9c45a96
Compare
|
@hitman99 I've tested this against a fresh Azure database, and it looks good. Could you review or give OK to merge? |
hitman99
approved these changes
Apr 5, 2025
|
Approved, thanks for testing this @pcallewaert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes obsolete code in the DropRole function that caused issues with PG16 (fixes #161, superseeds #162)
I did a small refactor of the Azure class so it is more clear what is code for Flexible and what code is for Single server. I would propose to remove the Single server code in a next major release as that offering is sunset at Azure.