Add optional annotations #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hitman99
requested changes
Aug 27, 2021
hitman99
approved these changes
Aug 27, 2021
|
@sboardwell It's merged to master. However, just after I merged I forgot to check if the readme was updated and it was not, would be kind and add info about the added functionality (annotation propagation) to the readme? To be specific, the |
|
Ok, no problem. |
|
Information added in #70 |
arni-wxnc
added a commit
to wuxi-nextcode/postgres-operator
that referenced
this pull request
Sep 16, 2021
* Added host and database_name to Kubernetes secret * Fixed indentation * WIP: operator-sdk update from v0.14.0 to v0.17.1 (movetokube#55) * operator-sdk update from v0.14.0 to v0.15.2 * operator-sdk update from v0.15.2 to v0.16.0 * operator-sdk update from v0.16.0 to v0.17.1 * operator-sdk update from v0.14.0 to v0.17.1 (movetokube#55) * operator-sdk update from v0.14.0 to v0.15.2 * operator-sdk update from v0.15.2 to v0.16.0 * operator-sdk update from v0.16.0 to v0.17.1 * Override DropRole method for Azure (movetokube#62) * Override DropRole method for Azure, the newOwner can be an invalid format for postgres * Refactor * Create FUNDING.yml * update readme with contribution notes (movetokube#64) Co-authored-by: Tomas Adomavicius <tomas.adomavicius@devbridge.com> * change base image to ubi8 (movetokube#59) update container base image to ubi8 * use ubuntu-latest instead of ubuntu-16 (movetokube#68) * add JDBC compliant URI to kubernetes secret (movetokube#69) * Add generated secret details to README.md * Add optional annotations (movetokube#66) Co-authored-by: lemstra.b <lemstra.b@tkppensioen.nl> Co-authored-by: Tomas <admin@hitman.lt> Co-authored-by: Tomas <tomas@adomavicius.com> Co-authored-by: Pieter C <pieter.callewaert@nipro-group.com> Co-authored-by: Tomas Adomavicius <tomas.adomavicius@devbridge.com> Co-authored-by: eapri <a@pouli.nl> Co-authored-by: Steve Boardwell <steve.boardwell@datameer.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR provides the user with the option of passing additional annotations to the secret.
Why?
Annotations allow the secret to be used with the pull based replication of the the kubernetes replicator.
There are likely to be be many other options.