Skip to content

Fix use of non-init provided typescript lib, use consistent imports #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

jakebailey
Copy link
Contributor

I mentioned this on #211 (comment), but, it was straightforward to send a PR for.

This PR:

  • Makes imports consistent, named tsModule and type imported.
  • Doesn't use any values from an imported typescript, as the one provided by init is the right one to be using.

@mrmckeb
Copy link
Owner

mrmckeb commented Mar 13, 2023

Great cleanup and community outreach, thanks @jakebailey!

@mrmckeb mrmckeb merged commit 19bb10d into mrmckeb:main Mar 13, 2023
@jakebailey jakebailey deleted the fix-ts branch March 13, 2023 21:52
calvellido referenced this pull request in arrow-kt/arrow-website Mar 22, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[typescript-plugin-css-modules](https://togithub.com/mrmckeb/typescript-plugin-css-modules)
| [`4.2.3` ->
`5.0.0`](https://renovatebot.com/diffs/npm/typescript-plugin-css-modules/4.2.3/5.0.0)
|
[![age](https://badges.renovateapi.com/packages/npm/typescript-plugin-css-modules/5.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/typescript-plugin-css-modules/5.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/typescript-plugin-css-modules/5.0.0/compatibility-slim/4.2.3)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/typescript-plugin-css-modules/5.0.0/confidence-slim/4.2.3)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>mrmckeb/typescript-plugin-css-modules</summary>

###
[`v5.0.0`](https://togithub.com/mrmckeb/typescript-plugin-css-modules/releases/tag/v5.0.0)

[Compare
Source](https://togithub.com/mrmckeb/typescript-plugin-css-modules/compare/v4.2.3...v5.0.0)

**Breaking changes:**

- TypeScript 4.x is now the minimum supported version
([@&#8203;mrmckeb](https://togithub.com/mrmckeb),
[https://github.com/mrmckeb/typescript-plugin-css-modules/pull/211](https://togithub.com/mrmckeb/typescript-plugin-css-modules/pull/211)).

**New features:**

- Added support for TypeScript 5.x
([@&#8203;mrmckeb](https://togithub.com/mrmckeb),
[https://github.com/mrmckeb/typescript-plugin-css-modules/pull/211](https://togithub.com/mrmckeb/typescript-plugin-css-modules/pull/211)).

**Bug fixes:**

- Fixed use of non-init provided TypeScript lib and move to consistent
`server` imports ([@&#8203;jakebailey](https://togithub.com/jakebailey),
[https://github.com/mrmckeb/typescript-plugin-css-modules/pull/213](https://togithub.com/mrmckeb/typescript-plugin-css-modules/pull/213)).

**New contributors:**

- [@&#8203;jakebailey](https://togithub.com/jakebailey) made their first
contribution in
[https://github.com/mrmckeb/typescript-plugin-css-modules/pull/213](https://togithub.com/mrmckeb/typescript-plugin-css-modules/pull/213).

**Full changelog:**
mrmckeb/typescript-plugin-css-modules@v4.2.3...v5.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/arrow-kt/arrow-website).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNC4yIiwidXBkYXRlZEluVmVyIjoiMzUuMTQuMiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants