Graceful shutdown support #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is difficult problem. If use msgpack-rpc-python as a stand alone server, then this code may be helpful. But msgpack-rpc-python is a library. What do you think? |
|
Hi @repeatedly , In my scenario, I'm run msgpack-rpc with Supervisord, and using msgpack-rpc added components to my main service. So when I upgrading my component, I'm using Supervisord send SIGHUP signal to msgpack-rpc server than restart it gracefully. When I have multiple components run base msgpack-rpc, this way added signal handling is the fast way and reduce codes for same job. I'd like hear some advises from you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm added some codes for graceful shutdown support, may be helpful. :P