Skip to content

compiler/prelude: format .js files using prettier #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2018

Conversation

myitcv
Copy link
Owner

@myitcv myitcv commented Jul 2, 2018

This PR introduces automatic formatting of the prelude's now separate
.js files. Using prettier has the same argument as using gofmt on .go
source code.

As part of this we make the go generate step for the prelude include a
formatpreludejs.go step.

The resulting prelude_min.go file is slightly different now, but post
gopherjs#791 we can see these
differences are entirely and solely attributable to prettier's adjusting
of the .js files.

This PR introduces automatic formatting of the prelude's now separate
.js files. Using prettier has the same argument as using gofmt on .go
source code.

As part of this we make the go generate step for the prelude include a
formatpreludejs.go step.

The resulting prelude_min.go file is slightly different now, but post
gopherjs#791 we can see these
differences are entirely and solely attributable to prettier's adjusting
of the .js files.
@myitcv myitcv merged commit 679d5dd into master Jul 2, 2018
@myitcv myitcv deleted the prettier_js_myitcv branch July 2, 2018 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant