Skip to content

compiler: upgrade to Go 1.12 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2019
Merged

compiler: upgrade to Go 1.12 #41

merged 1 commit into from
Mar 10, 2019

Conversation

myitcv
Copy link
Owner

@myitcv myitcv commented Dec 21, 2018 •
edited
Loading

Based on work by @hajimehoshi in gopherjs#900

@myitcv myitcv mentioned this pull request Dec 21, 2018
Closed
hajimehoshi
hajimehoshi reviewed Feb 27, 2019
View reviewed changes
@myitcv myitcv changed the title WIP - Go 1.12 [WIP] compiler: upgrade to Go 1.12 Mar 7, 2019
@myitcv myitcv force-pushed the go1.12 branch 3 times, most recently from fc32308 to 3b3f49e Compare March 7, 2019 20:31
@myitcv myitcv mentioned this pull request Mar 8, 2019
Merged
@myitcv myitcv force-pushed the go1.12 branch 10 times, most recently from ee36423 to 74abc70 Compare March 10, 2019 10:28
@myitcv myitcv requested a review from hajimehoshi March 10, 2019 14:22
@hajimehoshi hajimehoshi requested review from hajimehoshi and removed request for hajimehoshi March 10, 2019 14:53
hajimehoshi
hajimehoshi approved these changes Mar 10, 2019
View reviewed changes
Copy link
Collaborator

@hajimehoshi hajimehoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@myitcv myitcv changed the title [WIP] compiler: upgrade to Go 1.12 compiler: upgrade to Go 1.12 Mar 10, 2019
@myitcv myitcv merged commit 6177771 into master Mar 10, 2019
@myitcv myitcv deleted the go1.12 branch March 10, 2019 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hajimehoshi hajimehoshi hajimehoshi approved these changes

@AnikHasibul AnikHasibul AnikHasibul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myitcv @hajimehoshi @AnikHasibul