Skip to content

Fixing 99106 - Django 3 Unsupport backend error #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

ManZzup
Copy link

@ManZzup ManZzup commented Jul 14, 2020

Issue: https://bugs.mysql.com/bug.php?id=99106

This is a result of trying to import six from django.utils.six. Removal of six from utils was in Django 3 release notes.

This PR simply imports six from its own package: six

  • Will need to add six as a dependency for the lib
  • Might be breaking for python<3.0, but given taht python2 EOL has come, this shouldn't be a problem.

@ManZzup
Copy link
Author

ManZzup commented Jul 14, 2020

Just saw that this is a duplicate of 5413396

Leaving it here without closing to check if there's a possible reason for not merging the earlier PR

@kibblerz
Copy link

Do these changes happen to get the package working correctly with Django 3? Or is this only somewhat of a fix?

@mysql-oca-bot
Copy link

Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at http://www.oracle.com/technetwork/community/oca-486395.html
Please make sure to include your MySQL bug system user (email) in the returned form.
Thanks

@ManZzup
Copy link
Author

ManZzup commented Jul 17, 2020

Do these changes happen to get the package working correctly with Django 3? Or is this only somewhat of a fix?

I encountered this issue while running queries
Above methods seems to have a context param that's not used inside the method. I assume it's more of a compliance to the function signature. So i added null defaults to it would still be compatible with Django 3.0

I'm still running tests on Django 3.0, can confirm it's working as expected

@mysql-oca-bot
Copy link

Hi, there was no response to our request to sign an OCA or confirm the code is submitted under the terms of the OCA. As such this request will be closed.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants