Workaround for missing tokenDecimal for tokentx calls #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note on a Etherscan bug: Some ERC20 contract does not have valid decimals information in Etherscan. When that happen TokenName, TokenSymbol are empty strings, and TokenDecimal is 0. More information can be found at: #8
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
=========================================
+ Coverage 78.32% 78.73% +0.4%
=========================================
Files 10 10
Lines 263 268 +5
=========================================
+ Hits 206 211 +5
Misses 34 34
Partials 23 23
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #8 .
Some ERC20 contract does not have valid decimals information in Etherscan.
When that happens,
TokenName,TokenSymbolare empty strings,and
TokenDecimalwill be 0, instead of a unmarshaling error.More information can be found at: #8