Skip to content

actionbar is not rendered correctly in all pages excepts the startup page #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
odai-alali opened this issue Jul 4, 2018 · 4 comments
Closed

actionbar is not rendered correctly in all pages excepts the startup page #276

odai-alali opened this issue Jul 4, 2018 · 4 comments
Labels
priority:normal

Comments

@odai-alali
Copy link

Version

2.0.0-alpha.0

Reproduction link

https://github.com/odai-alali/ns-actionbar-test

Platform and OS info

windows 10, android 7.1

Steps to reproduce

run the application in the link

What is expected?

after taping the button and navigate to the second screen, the following action bar should be rendered

<ActionBar class="action-bar" title="Not Home Page">
      <ActionItem text="Action"></ActionItem>
    </ActionBar>

What is actually happening?

the default action bar is rendered with the application name as title and no other items

this works fine with v1.4.0-alpha.0 but broken in v2.0.0-alpha.0
msaelices added a commit to msaelices/nativescript-vue that referenced this issue Jul 4, 2018
@msaelices
Fix the app-with-pages.js sample by adding a Frame root element and a…
048d08a 
…dd two action bars in order to reproduce the issue nativescript-vue#276.
@msaelices msaelices mentioned this issue Jul 4, 2018
Merged
@msaelices
Copy link

PR for reproducing the issue: #278

msaelices added a commit to msaelices/nativescript-vue that referenced this issue Jul 5, 2018
@msaelices
Fix page composition when does navigation issue (nativescript-vue#276)…
edac50f 
…, which wraps an already Page component in another Page component, losing its action bar.
@msaelices
Copy link

msaelices commented Jul 5, 2018 •
edited
Loading

Issue solved in PR #278.

CC/ @rigor789

rigor789 pushed a commit that referenced this issue Jul 9, 2018
@msaelices @rigor789
fix: action bar rendering - issue #276 (#278)
db6df39 
* Fix the app-with-pages.js sample by adding a Frame root element and add two action bars in order to reproduce the issue #276.

* Fix page composition when does navigation issue (#276), which wraps an already Page component in another Page component, losing its action bar.
@rigor789
Copy link
Member

Fixed in 2.0.0-alpha.1

@nativescript-vue-bot
Copy link
Collaborator

We are locking this issue because it has been closed for more than 14 days.

If the issue comes up again please open a new issue with additional details.

@nativescript-vue nativescript-vue locked as resolved and limited conversation to collaborators Aug 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
priority:normal
Milestone
No milestone
Development

No branches or pull requests
4 participants
@msaelices @rigor789 @odai-alali @nativescript-vue-bot