Skip to content

fix style undefined with hmr #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix style undefined with hmr #1040

wants to merge 3 commits into from

Conversation

vallemar
Copy link
Contributor

@vallemar vallemar commented Apr 15, 2023 •
edited
Loading

I don't know why but this is breaking the hmr in my app, the _sov.get(property) returns undefined and when set to el.style[property] = originalValue; it breaks the app

Close: #1039

@vallemar vallemar marked this pull request as draft April 15, 2023 19:10
@vallemar vallemar marked this pull request as ready for review April 15, 2023 21:18
@vallemar
Copy link
Contributor Author

vallemar commented Apr 15, 2023 •
edited
Loading

I have found the root cause of the problem, the problem was that undefined was being saved when adding the style initially because el.style[property] was inserted and this has no value because it was inserted below. The value that will be added later to el.style[property] is now stored and in the hmr process the undefined value will not be found and it will not fail

@rigor789 rigor789 mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vue3 inline style HMR error
2 participants
@vallemar @rigor789