Samples refactoring to use a bundle app with webpack and support HMR and .vue files #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l-world NS-vue apps. Allow any aditional parameters to the tns command like --hmr or whatever.
…script as it is not useful now. Document new features
Codecov Report
@@ Coverage Diff @@
## dev #476 +/- ##
=======================================
Coverage 13.62% 13.62%
=======================================
Files 44 44
Lines 1211 1211
Branches 300 300
=======================================
Hits 165 165
Misses 821 821
Partials 225 225Continue to review full report at Codecov.
|
…samples infrastructure
rigor789
pushed a commit
that referenced
this pull request
May 31, 2019
…and .vue files (#476) * feat (samples): Run the samples using a webpack bundle. Closer to real-world NS-vue apps. Allow any aditional parameters to the tns command like --hmr or whatever. * feat (samples): Add a sample with a Vue component to check the HMR feature. * Change NPM dev script to build to dist/index.js. Remove the dev:dist script as it is not useful now. Document new features * feat (samples): Fix live reload when changing the NS-vue code * feat (sample): Adapt all the import to nativescript-vue * feat (samples): Separate the details page into a new .vue component for better UX * fix (samples): Fix the 455.js sample which is now adapted to the new samples infrastructure * chore (v-slot): Add sample (currently failing) for testing v-slot in a .vue component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the samples apps are closer to the real-world apps by using webpack and bundling the code and allowing to use HMR and any other
tnsoption if we run the code withnpm run samples -- --hmrAlso, it allows use of SFC
.vuefiles