Livesync/HMR fixes with the new (unreleased) NativeScript 6.0 #508
Conversation
* fix: loading of css when using webpack bundle * chore: add custom webpack.config in order to use bundle during the build using current nativescript-dev-webpack plugin 0.21 * chore: add travis file to orchestrate the testing flow and tests * fix: ios build in travis
…ativescript-dev-webpackl for the samples
…t-dev-webpack@webpack
Codecov Report
@@ Coverage Diff @@
## master #508 +/- ##
==========================================
+ Coverage 13.42% 14.07% +0.65%
==========================================
Files 45 44 -1
Lines 1229 1172 -57
Branches 306 297 -9
==========================================
Hits 165 165
+ Misses 833 784 -49
+ Partials 231 223 -8
Continue to review full report at Codecov.
|
|
@VladimirAmiorkov actually this branch should not be merged into We think to know if this branch will be a different non-backward-compatible NS-vue version or should we add conditions and checks to make it work properly in both versions. /CC @rigor789 |
|
Yes NS 6 brings many breaking changes which is why we are releasing a new major version. To me ti looks like supporting both NS 5 and NS 6 in a single code base is going to be not and easy task but its up to you. |
|
Agreed. I am for maintaining two different branches, but Rigor rules |
|
Question on this from a semver point of view as well understanding Rigor will ultimately decide. If we end up with two version of NS-Vue, one for NS 5 and one for NS 6, would it make sense to have the newer NS 6 compatible branch be a Major version change? Go to 3.x? Other thought would be to major both and end up with NS-Vue 5.x and NS-Vue 6.x so that it was pretty clear which versions were compatible with which version of NS core. However, that is a pretty drastic change in version numbering so it may not really help with clarity. |
|
@msaelices I've just talked to @sis0k0 about the release for 6.0, and the plan is to have a For 5.x we will release 2.3.0 stable, without any of the breaking changes, and that will likely be the last release for 5.x (unless we need to release a patch) @jawa-the-hutt it's a little tricky, because I'm trying to keep the version number somewhat semver friendly, but want to keep it similar to Vue's version. The plan is to release 3.x whenever I rewrite NSVue for Vue 3.x. I'm not sure if releasing a breaking change in 2.4 would cause issues for people though - we'll have to be a bit careful. |
See #507