Skip to content

Fix "TypeError: Cannot read property 'nativeView' of undefined" accessing this.$options #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2020
Merged

Fix "TypeError: Cannot read property 'nativeView' of undefined" accessing this.$options #602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e0fbcd
chore(samples): add sample app for reproducing #595
msaelices Jan 13, 2020
ef38874
fix: fix "TypeError: Cannot read property 'nativeView' of undefined" …
msaelices Jan 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion platform/nativescript/runtime/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ Vue.prototype.$start = function() {
// Define a `nativeView` getter in every NS vue instance
Object.defineProperty(Vue.prototype, 'nativeView', {
get() {
return this.$el.nativeView
return this.$el ? this.$el.nativeView : undefined
}
})

Expand Down
36 changes: 36 additions & 0 deletions samples/app/595.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
const Vue = require('nativescript-vue')

Vue.config.debug = true
Vue.config.silent = false

Plugin = {
install(Vue, name) {
Vue.prototype.$name = name

Vue.mixin({
beforeCreate: function() {
setTimeout(() => {
console.log('this.$options: ', this.$options)
}, 5000)
}
})
}
}

Vue.use(Plugin, 'pluginName')

new Vue({
data: {},
template: `
<Frame>
<Page>
<ActionBar title="Issue #595" />

<StackLayout>
<Label text="This app should not crash in 5 seconds" />
<Label text="You will see a dump of this.$options in console" />
</StackLayout>
</Page>
</Frame>
`
}).$start()