fix: add minor fix to allow target being passed to #614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Our testing infrastructure is not really set up properly, the only actual tests are functional tests. With Vue 3 around the corner, we're making testing a priority from the get-go. For now, I'm fine with not having proper tests for this change. I will have to check if #536 is affected if we are passing a target - as it may have been fixed upstream in NativeScript already. If it has been, I think we can safely revert #558 instead of introducing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor fix, per @rigor789's suggestion on #612. This works, however, it is not tested since there were not very clear testing guidelines. Also, it's not a very elegant solution. There may be times where you're not aware that an other modal is open, etc. and may not know if you need to pass
target. In that case, it's safer to just pass it. Anyway, I'm happy to discuss this further. Thanks!