Skip to content

Fixed Testing with the sample application(s) #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

brysem
Copy link

@brysem brysem commented Sep 2, 2020

Purpose:
The instructions for https://github.com/nativescript-vue/nativescript-vue/blob/master/CONTRIBUTING.md resulted in non-working sample application making contributing not possible without first fixing things.

Implemenation:
Added back the missing sample-runner, dependencies and changes made for NativeScript 7.*

Testing:
This PR can be tested by cloning the repository and following the instructions from https://github.com/nativescript-vue/nativescript-vue/blob/master/CONTRIBUTING.md

@brysem
Copy link
Author

brysem commented Sep 3, 2020

Fixed a merge conflict with master

@rigor789
Copy link
Member

rigor789 commented Sep 3, 2020

Thanks for the PR, most of the changes are not required in NS7 - the only piece we can bring back is the sample runner, however I have intentionally removed it, as it wasn't useful at all. With a recent refactor to use the entry.js file as the entry, any sample can be tested, just by changing the import in the entry.js file - without the need to restart the whole build process (much much faster).

The docs/contribution guide should be updated instead.

To get started with the repo:

  1. clone the repository
  2. cd nativescript-vue
  3. yarn - to install dependencies
  4. yarn dev - to build nativescript-vue and nativescript-vue-template-compiler in watch mode
  5. cd samples
  6. ns run <platform> --no-hmr (disabling hmr isn't necessary, but preferred most of the time)

To test a different/new sample:

  1. edit entry.js and update the require('./<sample>') statement to require any of the samples in the app folder.

@jarmani
Copy link

jarmani commented Nov 21, 2020

@rigor789 @brysem #751 only update the doc and should replace this one if you are ok with it.

@rigor789
Copy link
Member

Thanks for the PR, but closing this - as the removal was intentional and #751 addressed the missing documentation.

@rigor789 rigor789 closed this Nov 21, 2020
@brysem brysem deleted the sample_runner branch November 25, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants