Skip to content

Fixed matching of the markup and the result #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed matching of the markup and the result #225

wants to merge 1 commit into from

Conversation

Piterden
Copy link

No description provided.

@nativescript-vue-bot
Copy link

Deploy preview for nativescript-vue ready!

Built with commit f7cc893

https://deploy-preview-225--nativescript-vue.netlify.com

@rigor789
Copy link
Member

rigor789 commented Nov 6, 2018

I feel like this is too verbose as an example. We could add v-for which would be a tad bit better, but still not perfect as it includes more advanced markup. Maybe we could update the screenshot with shorter code.

@Piterden
Copy link
Author

Piterden commented Nov 6, 2018

But it is exactly that code, which result we see on the screenshot.

@rigor789
Copy link
Member

rigor789 commented Nov 8, 2018

@Piterden yes it is the code for the screenshot, but for documentation purposes it is way too verbose. I'm thinking we need to change both the sample code, and the screenshot to be the same, but shorter than the current one.

@ikoevska
Copy link
Contributor

@rigor789 I've opened an issue to rework scrollview docs based on your comment, so that we can close this PR.

@rigor789 rigor789 closed this Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants