Remove semicolon in data options for Sass #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the current config, it's not possible to use .sass files as the data option contains a semicolon.
|
@yerol I think the original genesis of this option was put in by your team to help with some things you are doing in Nativescript-Vue-Web. What impacts might there be from this change? |
|
The platform flag is used to pass which environment we are building for to sass compiler. This way we can have platform specific (conditional) styles. I don't think removing semicolon would break anything though. As long as the platform variable stays there, and not overridden/removed. |
|
@yassipad would you also please remove the semicolon from the .scss config just above the .sass config you had changed? This way we maintain a consistency between the two. |
|
Manually addressed in #19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current config, it's not possible to use .sass files as the data option contains a semicolon.