Adjust whitespace for better symmetry between Dockerfiles and cut image size in half by keeping fetch and compile in the same layer so the Python source goes away properly #1

tianon · 2015-12-30T23:31:05Z

No description provided.

tianon · 2015-12-30T23:32:03Z

Before: ~163.2 MB
After: ~89.05 MB

tianon · 2015-12-30T23:35:00Z

3.5/alpine/Dockerfile

+			| while read dep; do \
+				apk info --installed -q "$dep" && echo "$dep"; \
+			done \
+			| sort -u \


Is this second sort -u actually necessary? Our while loop has just filtered the output of the first sort, so this one should be a no-op.

Nevermind, figured out something simpler that skips the loop. 😄

…ge size in half by keeping fetch and compile in the same layer so the Python source goes away properly Before: ~163.2 MB After: ~89.05 MB

Adjust whitespace for better symmetry between Dockerfiles and cut image size in half by keeping fetch and compile in the same layer so the Python source goes away properly

ncopa · 2015-12-31T08:31:53Z

thanks! 👍

tianon mentioned this pull request Dec 30, 2015

[RFC] Add 3.5/alpine variant docker-library/python#74

Merged

tianon reviewed Dec 30, 2015
View reviewed changes

tianon force-pushed the alpine-tweaks branch 2 times, most recently from b7ef92d to f4cf226 Compare December 30, 2015 23:36

Adjust whitespace for better symmetry between Dockerfiles and cut ima…

9c5b00f

…ge size in half by keeping fetch and compile in the same layer so the Python source goes away properly Before: ~163.2 MB After: ~89.05 MB

tianon force-pushed the alpine-tweaks branch from f4cf226 to 9c5b00f Compare December 30, 2015 23:40

ncopa merged commit a418b4e into ncopa:alpine Dec 31, 2015

tianon deleted the alpine-tweaks branch December 31, 2015 18:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adjust whitespace for better symmetry between Dockerfiles and cut image size in half by keeping fetch and compile in the same layer so the Python source goes away properly #1

Adjust whitespace for better symmetry between Dockerfiles and cut image size in half by keeping fetch and compile in the same layer so the Python source goes away properly #1

Uh oh!

tianon commented Dec 30, 2015

Uh oh!

tianon commented Dec 30, 2015

Uh oh!

tianon Dec 30, 2015

Uh oh!

tianon Dec 30, 2015

Uh oh!

ncopa commented Dec 31, 2015

Uh oh!

Uh oh!

Adjust whitespace for better symmetry between Dockerfiles and cut image size in half by keeping fetch and compile in the same layer so the Python source goes away properly #1

Adjust whitespace for better symmetry between Dockerfiles and cut image size in half by keeping fetch and compile in the same layer so the Python source goes away properly #1

Uh oh!

Conversation

tianon commented Dec 30, 2015

Uh oh!

tianon commented Dec 30, 2015

Uh oh!

tianon Dec 30, 2015

Choose a reason for hiding this comment

Uh oh!

tianon Dec 30, 2015

Choose a reason for hiding this comment

Uh oh!

ncopa commented Dec 31, 2015

Uh oh!

Uh oh!