-
-
Notifications
You must be signed in to change notification settings - Fork 6k
feat(provider)!: remove support for python2 and python3.[3-6] #17222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3.6 is technically EOL too, but I guess that's too soon? |
@fsouza perhaps we should. I was just going by neovim/pynvim#492 at this point :] |
4902eaf
to
7a1c844
Compare
2cad9c3
to
b5eb3b7
Compare
Tests are updated and doc reviews addressed. |
These versions of python has reached End-of-life. getting rid of python2 support removes a lot of logic to support two incompatible python versions in the same version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor docnits, otherwise LGTM. (Love those diffstats :])
@bfredl, hi
But I think my python is ok ?
and
This seems to be from pythonx.vim -
Do you know where the major_version could be getting set (to 2) ? |
ok, I think its the vimade plugin. I will look into that and work with that developer. |
I am using "vim-plug" as my plugin manager. Since this PR was merged, I can't use I found out that it is because There may be a situation where all plugins that use DEMO (mp4):
Kapture.2022-01-31.at.11.29.28.mp4 |
You might need to clean out stale runtime files like this suggests. #17252 (comment) |
I always build Neovim with |
Thanks so much. |
These versions of python has reached End-of-life. getting rid of python2 support removes a lot of logic to support two
incompatible python versions in the same version.
Note: this is a draft but not marked as such because I want to see all mayhem this causes in CI at once.
Note: as currently
has("python")
will return false whilehas("python3")
andhas("pythonx")
will return true when available. I am inclined to not change this as this is the only way plugins can check that python2 is not supported without new special logic for neovim 0.7+ only. However if the user/plugin uses:python
/pyeval()
without checkinghas()
we will give them python, that is python3, as they asked, as python now unambiguously means python3.