feat(terminal): parse current buffer contents in nvim_open_term() #33720
+52
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces functionality to parse and send non-empty buffer contents through the PTY when nvim_open_term() is called. Key changes include:
- Modifying documentation to indicate that non-empty buffers will have their contents written to the PTY.
- Adding logic to read and concatenate buffer lines, appending newline characters as needed.
- Sending the concatenated contents to the channel after opening the terminal.
Files not reviewed (3)
- runtime/doc/api.txt: Language not supported
- runtime/lua/vim/_meta/api.lua: Language not supported
- test/functional/api/vim_spec.lua: Language not supported
When nvim_open_term() is called with a non-empty buffer, the buffer contents are piped into the PTY.
ebdd132 to
96351ae
Compare
zeertzjq
reviewed
Apr 29, 2025
| for (linenr_T lnum = 1; lnum <= buf->b_ml.ml_line_count; lnum++) { | ||
| char *bufstr = ml_get_buf(buf, lnum); | ||
| colnr_T bufstrlen = ml_get_buf_len(buf, lnum); | ||
| kv_concat_len(contents, bufstr, (size_t)bufstrlen); |
There was a problem hiding this comment.
Translate NL to Nul when concatenating? And this shares some common code with read_input() in src/nvim/os/shell.c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When nvim_open_term() is called with a non-empty buffer, the buffer contents are piped into the PTY.