[RDY] Coverity fix resource leaks 1b #804
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// @param name The name of the register | ||
| /// @param str The contents to write | ||
| /// @param len If >= 0, write `len` bytes of `str`. Otherwise, write | ||
| /// `strlen(str)` bytes. If `maxlen` is larger than the |
There was a problem hiding this comment.
Another maxlen -> len replacement.
There was a problem hiding this comment.
Wow, this is getting ridiculous. I'll wait a few minutes to see if you pick out another stupid omission I made.
Closed
Also constified the arguments. The double casts for the `xstrdup` are ugly but `vim_strsave` doesn't take `const` arguments for now so I couldn't keep that.
Coverity detected a memory leak caused by not free'ing the value returned by get_expr_line_src (basically vim_strsave(expr_line)). Replaced the copying with direct manipulation of expr_line, since that also happens in other parts of the codebase. NOTE: I'm aware that this has different behaviour than vim_strnsave, namely vim_strnsave always allocates `len` bytes, even if the string is shorter. I don't see how that behaviour is helpful here though.
Also cleaned up the function a little bit.
It was a false positive, but it can't hurt to "fix" it. Original warning: CID 13685 (#1 of 1): Buffer not null terminated (BUFFER_SIZE) 6. buffer_size: Calling strncpy with a source string whose length (4 chars) is greater than or equal to the size argument (4) will fail to null-terminate b0p->b0_version.
|
@Hinidu decided to rebase, fixed the |
|
@aktau 👍 :-) |
justinmk
added a commit
that referenced
this pull request
Jun 12, 2014
|
Merged! |
dwb
pushed a commit
to dwb/neovim
that referenced
this pull request
Feb 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because github is messing up and doesn't seem to even refer to travis anymore on PR #790, I've cherry-picked the relevant commits and posted them here.