Skip to content

Added a link and a front-image for my slug #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2015
Merged

Added a link and a front-image for my slug #124

merged 1 commit into from
Nov 28, 2015

Conversation

rhizoome
Copy link
Contributor

I was a bit surprised that I ended up on the front page of neovim.io. So I created a small page with few information about what I am working on.

justinmk added a commit that referenced this pull request Nov 28, 2015
@justinmk
Merge pull request #124 from ganwell/master
c79a88c 
Added a link and a front-image for my slug
@justinmk justinmk merged commit c79a88c into neovim:master Nov 28, 2015
@justinmk
Copy link
Member

Thanks a lot!

@tarruda
Copy link
Member

tarruda commented Nov 29, 2015

Thank you 😄

@tarruda
Copy link
Member

tarruda commented Nov 29, 2015

@ganwell there's now an issue because the front image URL comes from http and not https. Here's what chromium reports:

Mixed Content: The page at 'https://neovim.io/' was loaded over HTTPS, but requested an insecure image 'http://1042.ch/ganwell.png'. This content should also be served over HTTPS.

and

Image from origin 'http://1042.ch' has been blocked from loading by Cross-Origin Resource Sharing policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'https://neovim.io' is therefore not allowed access.

Any chance you can provide an https url for your front page image? Nevermind, I just added the image to the repository and fixed the URL

@rhizoome
Copy link
Contributor Author

@tarruda Thanks for fixing that. I totally forgot about the "Cross-Origin Resource Sharing" problem. And also thanks for the great software.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhizoome @justinmk @tarruda