Skip to content

pynvim needs to be updated to use pyproject.toml #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crowellel opened this issue Nov 4, 2022 · 4 comments
Closed

pynvim needs to be updated to use pyproject.toml #518

crowellel opened this issue Nov 4, 2022 · 4 comments

Comments

@crowellel
Copy link
Contributor

When I just recently installed pynvim, I was presented with a deprecation warning that stated that starting in pip ver 23.1, pip will require compliance with using a pyproject.toml file for module installation, instead of the legacy setup.py file that pynvim currently uses. Therefore I would recommend updating the package and migrating to a pyproject.toml file for setup as soon as possible to avoid having installation broken when pip starts forcing compliance.
@justinmk
Copy link
Member

justinmk commented Nov 7, 2022

any chance you could send a PR?

@crowellel
Copy link
Contributor Author

I was actually considering doing just that. I've just never worked with packaging before so I figured this would be a good learning opportunity. I'll send the PR once I get it done. I estimate two weeks due to current time constraints.

@zachliu
Copy link

zachliu commented Nov 10, 2022

just saw the same msg today

DEPRECATION: pynvim is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at https://github.com/pypa/pip/issues/8559

@badboy1cdx thank you in advance!

@crowellel crowellel mentioned this issue Nov 18, 2022
Merged
@crowellel
Copy link
Contributor Author

PR has been submitted. See: #519

justinmk pushed a commit that referenced this issue Jan 26, 2023
@crowellel
packaging: conform to PEP 517 guidelines #519
496e8eb 
Problem:
Not compliant with python packaging standards.
Deprecation warnings from pip due to outdated packaging format.
ref #518

Solution:
- Conform to PEP 517 packaging guidelines
- Change packaging and uploading commands in README to allow for building and
  uploading a source distribution as well as a wheel.
- Added language to setup.py to create universal wheel (necessary for continuing
  py2.7 compatibility - even if py2.7 is EOL).
- Add minimal pyproject.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@justinmk @zachliu @crowellel