Skip to content

ci: run tests on GitHub Actions #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 14, 2023
Merged

ci: run tests on GitHub Actions #526

merged 4 commits into from
Jul 14, 2023

Conversation

justinmk
Copy link
Member

No description provided.

@justinmk justinmk force-pushed the ci branch 6 times, most recently from 64017ba to 8173277 Compare July 14, 2023 19:24
@justinmk
ci: use "pip3" instead of "pip"
8a2a3b8 
Problem:
With actions/setup-python@v4, "pip" still implies python2 (on macOS at least), wtf?

    Run pip install .  # Install from setup.py
    DEPRECATION: Python 2.7 reached the end of its life on January 1st,
    2020. Please upgrade your Python as Python 2.7 is no longer maintained. ...

Solution:
Use "pip3" and "python3" explicitly. 🤦🏿
@justinmk
Copy link
Member Author

Windows tests still failing, but this is better than nothing, so merging.

@justinmk justinmk merged commit 19127b2 into master Jul 14, 2023
@justinmk justinmk deleted the ci branch July 14, 2023 19:59
@justinmk justinmk mentioned this pull request Jul 14, 2023
Merged
@justinmk justinmk mentioned this pull request Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@justinmk